Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Simplified rclimit management when payer is another wallet #168

Open
1 task done
lukemwillis opened this issue Dec 5, 2022 · 4 comments
Open
1 task done
Labels
bug Something isn't working task

Comments

@lukemwillis
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

New feature

Currently, managing rclimit with delegated mana is manual.

🔓 > rclimit
Current rc limit: 10.000000

🔓 > rclimit 100
Set rc limit to 100.000000

🔓 > upload contract.wasm contract.abi
cannot upload contract, payer does not have the rc to cover transaction rc limit

🔓 > rclimit 90
Set rc limit to 90.000000

🔓 > upload contract.wasm contract.abi
Contract uploaded with address <some-address>
Transaction with ID <some-id> containing 1 operations submitted.
Mana cost: 11.20280306 (Disk: 43604, Network: 48962, Compute: 680636)

If the delegator has a lot of mana, it's easy, but it would be easier if you could set it as a percentage of the payer's mana balance. Similar to the default experience where it's set to 100% of the current wallet's mana balance.

🔓 > rclimit
Current rc limit: 100.000000% (10117.572038)

Anything else?

No response

@lukemwillis lukemwillis added the enhancement New feature or request label Dec 5, 2022
@sgerbino
Copy link
Member

sgerbino commented Dec 5, 2022

You should be able to do: rclimit 10%, is that the feature you are proposing?

Ah, when you set rclimit 10% it should consider who the payer is. That makes sense.

@koinos-ci
Copy link

This issue is stale because it has been open for 30 days with no activity.

@mvandeberg mvandeberg added task and removed stale labels Mar 3, 2023
@sgerbino sgerbino added bug Something isn't working task and removed enhancement New feature or request task labels Mar 17, 2023
@roaminro
Copy link
Contributor

roaminro commented Jun 11, 2023

FYI, the line that needs to be udpated:

limit, err := ee.RPCClient.GetAccountRc(ctx, ee.Key.AddressBytes())

Should be

limit, err := ee.RPCClient.GetAccountRc(ctx, ee.GetPayerAddress())

@mvandeberg
Copy link
Member

If it is a one line change, could you make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task
Projects
None yet
Development

No branches or pull requests

5 participants