Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Links #18

Open
kohheepeace opened this issue Jun 4, 2021 · 6 comments
Open

Internal Links #18

kohheepeace opened this issue Jun 4, 2021 · 6 comments
Labels
bug Something isn't working difficult help wanted Extra attention is needed

Comments

@kohheepeace
Copy link
Owner

#10 (comment)

After adding TOC, internal links didn't work. So, the HTML parse for TOC is related.

@idontknowjs
Copy link

@kohheepeace As I remember even before adding TOC - internal links were not working!

@kohheepeace
Copy link
Owner Author

@CovalentBond I think you are right.

@kohheepeace kohheepeace added difficult help wanted Extra attention is needed labels Jun 4, 2021
@kohheepeace
Copy link
Owner Author

kohheepeace commented Jun 4, 2021

[memo]
There are two types of internal links.

  1. link to another doc <a href="/stable/troubleshoot/troubleshooting">
  2. Link to another heading <a href="#...">

After TOC feature, I think 2 become not working.

For internal link 1,

  1. Add id to each article: <article id="/stable/troubleshoot/troubleshooting">
  2. Convert <a href="/stable/troubleshoot/troubleshooting" to <a href="#/stable/troubleshoot/troubleshooting"

To find the exact path looks difficult.
Ref: kohheepeace/docusaurus-pdf#2

@idontknowjs
Copy link

@kohheepeace any updates on this issue?

@krillboi
Copy link

krillboi commented Aug 6, 2021

Since internal links are not working, is it possible to have an option to disable the generation of the TOC page? I manually disable all hyperlinks in my PDF and as such the TOC is not that useful when you cannot click any of them and I haven't found an option to skip the TOC.

@Lena-Pan
Copy link

kohheepeace/docusaurus-pdf#2

@kohheepeace
we are trying this workaround, did not quite get "Add id to each article: ", can you give an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working difficult help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants