-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox media keys #1236
Comments
I had no idea that Firefox added Media Control support, pretty cool! I looked into this and as of Firefox 81 these are enabled by default: The docs currently say:
It sounds like this extended to Firefox now too, but if we are going to update the docs, we should check if we can say on "modern browsers", thus including Safari, Brave, etc. Or if things should be written specifically to Firefox and Chromium-based browsers. Once that's been determined, a PR can be made on the docs site: |
Isn't it now a norm on macOS? I don't own a Windows anymore (since like forever), so I can't really confirm this. |
I did some testing on macOS 11 with Safari 13 and didn't work as smoothly as in Chromium or Firefox. I decided to make a PR leaving out Safari for now, it may work but this is at least an improvement. |
Firefox now supports media keys (right now has to be enabled in about:config): https://www.ghacks.net/2020/03/23/firefox-will-soon-support-hardware-media-controls/ . As long as media.hardwaremediakeys.enabled and dom.media.mediasession.enabled are set to true, this feature now works in Firefox with no changes to Koel (tested with 78.0.2 on Windows 10). You should mention this in the documentation.
The text was updated successfully, but these errors were encountered: