Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests for extensions option #67

Open
haoxins opened this issue Jan 10, 2017 · 1 comment
Open

add more tests for extensions option #67

haoxins opened this issue Jan 10, 2017 · 1 comment

Comments

@haoxins
Copy link
Member

haoxins commented Jan 10, 2017

  • should not search if path has extension
  • should skip directories
@Necromos
Copy link
Contributor

Necromos commented Jan 17, 2017

@coderhaoxin

  • should not search if path has extension
  • should skip directories
    • Well I didn't knew what it should do in this case, right now when GET /someDirectory/ is called it will try to deconstruct path and search for /someDirectory{.extension} which may be not really wanted behaviour. Should we omit extension checking if directory is called?

@haoxins haoxins mentioned this issue Feb 22, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants