Please add windows support

[Siebjee]

Please add windows support, i got a working copy ready, however i can't get travis to agree on it.
Please check it out: https://bitbucket.org/ownbaws/bamboo_agent

Please note, it contains breaking changes to existing code. It isn't a drop-in replacement.

[jgnagy]

@Siebjee thanks for the feature request! We're happy to take a look at adding Windows support, though things would go much faster with a pull request if you already have a working branch. Can you submit a pull request and leave it open for us to investigate? We might be able to help solve the travis issues if the rest of the code works.

As for breaking changes, we prefer not to have those and instead provide sane default configurations that retain existing functionality while providing the options for new features, at least whenever possible. We can assess or comment on that further when we see the code.

[Siebjee]

Hi Jonathan, Thank you for responding! I do have a working copy of the code for windows. Linux part still has to be re-tested but I'm sure it will work. As for the breaking changes i might be able to solve this. I introduced a params.pp for defaults. That's why parts could break. Also I introduced a new parameter to the bamboo_agent::agent resource, called bamboo_user_home and bamboo_agent_home. In my specific case I had to separate them. But defaults to the user home. Would also be nice for other people in my opinion. I'll review the code again, build in the required backwards compatibility. And submit a pull request once done. Met vriendelijke groet / With kind regards, Siebren Zwerver

…

Sent from my iPhone

On 7 Jul 2017, at 21:24, Jonathan Gnagy ***@***.***> wrote: @Siebjee thanks for the feature request! We're happy to take a look at adding Windows support, though things would go much faster with a pull request if you already have a working branch. Can you submit a pull request and leave it open for us to investigate? We might be able to help solve the travis issues if the rest of the code works. As for breaking changes, we prefer not to have those and instead provide sane default configurations that retain existing functionality while providing the options for new features, at least whenever possible. We can assess or comment on that further when we see the code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[Siebjee]

Hi Jonathan,

I believe i fixed all breaking changes back to the original state.
You can find this all in: #9

Please note in the metadata.json i have removed 1 dependency, r9util, i have replaced this with stdlib: file_line to be compatible with windows and linux. And added the puppetlabs-powershell as dependency to add services in windows.