Added Open and LoadWithCompiled to Host methods #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvolod
reviewed
May 14, 2023
| @@ -183,6 +183,145 @@ func genHost(g *protogen.GeneratedFile, f *fileInfo, service *serviceInfo) { | |||
| service.GoName, | |||
| )) | |||
|
|
|||
| // Open and LoadWithCompiled Functions | |||
There was a problem hiding this comment.
@Ice3man543 , it's seem to applicable approach, but for common functionality Load can be combination of the Open and LoadWithCompile
Also cache option recommenced by @codefromthecrypt can be validated to choose this approach or compilation cache.
There was a problem hiding this comment.
I've tried the cache approach and it's working fine. Closing!
There was a problem hiding this comment.
I recently came to more or less same issue, could you please share some links or docs on what is "cache approach" in context of go-plugin that you refer to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #50
Description of changes:
Added
OpenandLoadWithCompiledto Host interface methods.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.