Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knope detects incorrect version from tags #322

Closed
Shadow53 opened this issue Nov 16, 2022 · 2 comments · Fixed by #323
Closed

Knope detects incorrect version from tags #322

Shadow53 opened this issue Nov 16, 2022 · 2 comments · Fixed by #323

Comments

@Shadow53
Copy link
Collaborator

The current code seems to assume that Platform::tags() returns tags in the correctly sorted order, which it does not. It appears to return the same order as git tag, which sorts, e.g. 0.1.0, 0.10.0, 0.2.0.

I've written a fix for this that compares tag versions before deciding that one is a new version, and will open a PR after submitting this issue.

@notmgsk
Copy link

notmgsk commented Nov 16, 2022

For context: rigetti/quil-rs#123

@dbanty
Copy link
Member

dbanty commented Nov 17, 2022

Silly me assuming it would give me the latest git tag 🫠. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants