Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaving full screen mode tricky #8

Open
ghost opened this issue Nov 2, 2017 · 2 comments
Open

Leaving full screen mode tricky #8

ghost opened this issue Nov 2, 2017 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 2, 2017

Because people may not realise the app switched the device to landscape mode they will try to swipe down on the wrong side.

Perhaps there could be a few options offered in the "i" menu as well? Or yet another button?

@kloener
Copy link
Owner

kloener commented Nov 7, 2017

You're right! It's not obvious where to escape the fullscreen mode... I'm not a friend of yet another button, but a settings/options menu would be useful to enable/disable the immersive mode. Furthermore, it can be used to change camera's resolution 🤔 ...

@ghost
Copy link
Author

ghost commented Nov 7, 2017 via email

morckx added a commit to morckx/visor-android that referenced this issue Sep 26, 2020
* for lighting / start up behavior
* for notifications sounds
* use default shared preferences (which are by default in PRIVATE_MODE)
* use the resource strings as identifiers rather than their integer values that to not stay constant between builds

As the settings activity does not run in fullscreen, this helps with kloener#8
morckx added a commit to morckx/visor-android that referenced this issue Oct 10, 2020
* for lighting / start up behavior
* for notifications sounds
* use default shared preferences (which are by default in PRIVATE_MODE)
* use the resource strings as identifiers rather than their integer values that to not stay constant between builds

As the settings activity does not run in fullscreen, this helps with kloener#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant