Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept input straight away, not after loading #9

Open
ghost opened this issue Oct 8, 2016 · 3 comments
Open

Accept input straight away, not after loading #9

ghost opened this issue Oct 8, 2016 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 8, 2016

Sometimes I come to the site knowing exactly what search I want to type but the input field doesn't accept input until the packages have loaded. It's not a big deal to wait, just a little thing.

@klaftertief
Copy link
Owner

This is because the search used to be a live search and the disabled input prevented searches with an empty index. Disabling the submit button is good enough now. Will publish a new version soon. Thanks for the input.

klaftertief pushed a commit that referenced this issue Oct 30, 2016
This is a partial fix for #9. One can already type into the field when the index gets parsed, though browser will propably not show the input as the parsing blocks rendering. The text will show up in the input once the parsing is done.
It may be worth implementing async parsing.
@klaftertief
Copy link
Owner

You can now type into the search field and it will be focused on page load.
Though the browser will probably not show what you are typing as the parsing go the index is blocking.
Will think about making it async so that it won't block.

@ghost
Copy link
Author

ghost commented Oct 30, 2016

So good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant