Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (indexer): specify all main dependencies and sub-dependencies version in the indexer/deps.ts file #1548

Open
Eikix opened this issue Nov 26, 2024 · 3 comments
Open

fix (indexer): specify all main dependencies and sub-dependencies version in the indexer/deps.ts file #1548

Eikix opened this issue Nov 26, 2024 · 3 comments
Assignees
@pheobeayo
Labels
dependencies Change in project dependencies. enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project. priority-high After critical issues are fixed, these should be dealt with before any further issues. time: small timebox-1hr Exploratory issue: Do not spend more than an hour on it to assess doability.

Comments

@Eikix
Copy link
Member

Eikix commented Nov 26, 2024

Describe the enhancement request

RPC of Kakarot Sepolia was down this Saturday 23rd November 2024, because of an ethereumJS broken import due to minor bump of versions.
Error message:

sink configuration error
├╴at /build/source/sinks/sink-common/src/error.rs:195:14
├╴failed to load configuration from script
│
╰─▶ indexer script operation failed
    ├╴at /build/source/script/src/script.rs:340:22
    ├╴failed to run indexer event loop
    ╰╴error: SyntaxError: The requested module '/v135/@ethereumjs/[email protected]/esnext/statemanager.mjs' does not provide an export named 'getTreeIndexesForStorageSlot' at https://esm.sh/v135/@ethereumjs/[email protected]/esnext/evm.mjs:3:16725
          at async [script]:2:32

image

Problem was caused by two different issues:

  • ethereumjs had a breaking change in a minor version by breaking their exports
  • indexer software does not use lockfile

Short term fix was back port fix the 0.7.5 tag using this branch apoorvsadana/kkrt-backport:v0.7.5-fix
URL: e0eaa76

Describe Preferred Solution

Following what was done in e0eaa76,
specify all main deps version in the import url indexer/deps.ts. Basically extend the current fix with all deps not just the minimal set like now
@Eikix Eikix added the enhancement Enhancement of the code, not introducing new features. label Nov 26, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Nov 26, 2024
@Eikix Eikix moved this from 🆕 Backlog to 🔖 Current sprint in Kakarot on Starknet Nov 26, 2024
@Eikix Eikix moved this from 🔖 Current sprint to 🆕 Backlog in Kakarot on Starknet Nov 26, 2024
@Eikix Eikix added good first issue Good first issue for people wanting to contribute to this project. priority-high After critical issues are fixed, these should be dealt with before any further issues. dependencies Change in project dependencies. timebox-1hr Exploratory issue: Do not spend more than an hour on it to assess doability. time: small labels Nov 26, 2024
@pheobeayo
Copy link

I'd love to give this a go.

@Eikix
Copy link
Member Author

Eikix commented Nov 26, 2024

Sure! Letting you know that the PR should be done today, otherwise, we'll do it internally. Thank you for understanding the priority on this.

@Eikix Eikix moved this from 🆕 Backlog to 🏗 In progress in Kakarot on Starknet Nov 26, 2024
@pheobeayo
Copy link

working right on it @Eikix

pheobeayo pushed a commit to pheobeayo/kakarot-rpc that referenced this issue Nov 26, 2024
fix issue kkrt-labs#1548
d1f5ea3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pheobeayo pheobeayo

Labels
dependencies Change in project dependencies. enhancement Enhancement of the code, not introducing new features. good first issue Good first issue for people wanting to contribute to this project. priority-high After critical issues are fixed, these should be dealt with before any further issues. time: small timebox-1hr Exploratory issue: Do not spend more than an hour on it to assess doability.
Projects
No open projects
Kakarot on Starknet
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pheobeayo @Eikix