Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: update usage of apibara binaries [1] #1186

Open
greged93 opened this issue Jun 13, 2024 · 2 comments
Open

dev: update usage of apibara binaries [1] #1186

greged93 opened this issue Jun 13, 2024 · 2 comments
Labels
ci Work that improves the continuous integration. enhancement Enhancement of the code, not introducing new features.

Comments

@greged93
Copy link
Collaborator

greged93 commented Jun 13, 2024 •
edited
Loading

Describe the enhancement request
Currently to use the apibara binaries, we pull the image and then navigate the folders in order to pull the binary, which we then need to patch depending on the architecture used.

This can actually all be replaced by the following code:
https://gist.github.com/fracek/6a05a9986d3c3ba908bb086589733c4b

The issue will be deemed finished when:

  • All the docker files that use apibara binaries now use the above code for it.
  • All docker files can be build and executed.
  • Hive tests pass.

Duration: 1 hour
@greged93 greged93 added the enhancement Enhancement of the code, not introducing new features. label Jun 13, 2024
@greged93 greged93 added the ci Work that improves the continuous integration. label Jun 13, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this issue Aug 9, 2024
@fabrobles92
Adding Unit tests for set_nonce and set_implementation (kkrt-labs#1202)
774e7ff 
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR: 1 day

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [X] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves kkrt-labs#1186 

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

-New unit test for set_nonce
-New unit test for set_implementation
-New cairo func called test__set_nonce
-New cairo func called test__set_implementation

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1202)
<!-- Reviewable:end -->
@Eikix
Copy link
Member

Eikix commented Oct 2, 2024

Fran:

The only issue is that it always fetch the latest version. You can adapt the bash script to fetch a specific version

https://install.apibara.com/install.sh

Update: this issue is still fresh and should be tackled as part of our continuous improvement track

@Eikix
Copy link
Member

Eikix commented Oct 22, 2024

Update:
This issue constitutes a succinct yet important step towards CI stability and ease of maintenance.

❌ It needs to be enriched with a tech strategy to be assignable,

Cc'ing @ClementWalter for next engineering strategy

@Eikix Eikix moved this from 🆕 Backlog to 📅 Next sprint in Kakarot's Project Management Oct 22, 2024
@greged93 greged93 changed the title dev: update usage of apibara binaries dev: update usage of apibara binaries [1] Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Work that improves the continuous integration. enhancement Enhancement of the code, not introducing new features.
Projects
Kakarot's Project Management
Status: 🔖 Current sprint
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eikix @greged93