This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Add smoke tests #276
Merged
Add smoke tests #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
commented
Nov 28, 2023
| env: | ||
| URI: ${{needs.build.outputs.uri}} | ||
| run: | | ||
| echo "Sleeping 1 minute due to https://github.com/Azure/azure-dev/issues/2669" |
There was a problem hiding this comment.
I do wonder if we want to do this a fancier way. We could even write a Python script using tenacity to check for 200 status with backoff and 10 attempts, that sort of thing. Or we could do that in bash (barf).
There was a problem hiding this comment.
I think we can make it cooler later... this works for now (unless it doesn't)
There was a problem hiding this comment.
It does seem to work so far! We'll see what happens when we cruft update on all 17 repos.
|
Tested this update here: https://github.com/Azure-Samples/azure-flask-postgres-flexible-appservice/pull/13/files |
kjaymiller
approved these changes
Nov 29, 2023
This was referenced Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.