Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

ruff formatter won't save changes made #286

Open
kjaymiller opened this issue Nov 30, 2023 · 2 comments
Open

ruff formatter won't save changes made #286

kjaymiller opened this issue Nov 30, 2023 · 2 comments

Comments

@kjaymiller
Copy link
Owner

ruff formatter is added to the github action... however there is no logic to persist the changes after they've been made.

I've created the logic before here - https://github.com/render-engine/render-engine/blob/ded3baeff9a584d0c494cf8cf7266fbebb004f0b/.github/workflows/lint.yml#L45C1-L54C11

but I'm not sure if the Azure-Samples policy will allow for commiting changes as it did require

permissions:
    contents: write
    pull-requests: write
@pamelafox
Copy link
Collaborator

I prefer pre-commit to having GitHub actions do linting + checkin, since then you have to remember to pull the latest updates changes in your local branch. Also am not sure if we're talking about actions on this repo or on the generated repos?

@kjaymiller
Copy link
Owner Author

Also am not sure if we're talking about actions on this repo or on the generated repos?

These would be the generated repos

I also agree in this instance using pre-commit to ensure changes made fit the style of the projects is better.

I don't mind the GitHub issue creation as it creates a point where you clearly know where the changes came from (i.e. was this decision one from pre-commit and approved by the user or one that was made in linting and added under the account of my-linting-bot) I agree we should proceed and add #287

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants