Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary space below search bar when screen is narrow #1214

Open
Jaifroid opened this issue Feb 22, 2024 · 9 comments
Open

Remove unnecessary space below search bar when screen is narrow #1214

Jaifroid opened this issue Feb 22, 2024 · 9 comments

Comments

@Jaifroid
Copy link
Member

Although this is not noticeable on desktop, on narrow form factors, the excessive amount of space below the search bar is extremely noticeable. While the ultimate solution to this is #523, in the meantime, it would be a quick fix to remove the space now. See screenshot.

image

@Sky-De
Copy link

Sky-De commented Feb 23, 2024

@Jaifroid i would like to fix this issue, please assign this to me

@Jaifroid
Copy link
Member Author

@Sky-De Please take a look at https://github.com/kiwix/kiwix-js/blob/main/CONTRIBUTING.md (read it all the way through), set up your development environment, and make sure you're happy with the process here. If all is well, please come back here outlining your suggestion of how to complete this issue so that I can assign you.

@Sky-De
Copy link

Sky-De commented Feb 23, 2024

@Jaifroid i will do that tomorrow and I'll inform you, thanks for quick response

@Aditya0049
Copy link

Aditya0049 commented Feb 25, 2024

Before
Screenshot 2024-02-26 004445

After
Screenshot 2024-02-26 004502

check here #1216
Let me know if any change @Jaifroid

@Aditya0049
Copy link

can you merge PR @Jaifroid

@amr-salahuddin
Copy link

Have this issue been solved already?

@Jaifroid
Copy link
Member Author

Have this issue been solved already?

@amr-salahuddin Yes, @Aditya0049 already has a PR:

@Jaifroid Jaifroid modified the milestones: v4.1, v4.2 Jul 14, 2024
@CREDO23
Copy link

CREDO23 commented Nov 26, 2024

I want to work on this @Jaifroid !

@Jaifroid
Copy link
Member Author

OK. Please check out the previous PR and what was wrong with it. Be sure to follow instructions in CONTRIBUTING.md so you know how to set up your development environment and test properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants