Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests on Firefox sometimes assert in TestCafé before the test has finished (so they fail) #1058

Closed
Jaifroid opened this issue Aug 18, 2023 · 3 comments
Closed

Unit tests on Firefox sometimes assert in TestCafé before the test has finished (so they fail) #1058

Jaifroid opened this issue Aug 18, 2023 · 3 comments
Assignees
@Jaifroid
Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix tests
Milestone
v4.1

Comments

@Jaifroid
Copy link
Member

Seems to be a timeout issue, which TestCafé is supposed to be immune to. We might have to force the driver to sleep for a while, even though this is not supposed to be a thing with TestCafé.
@Jaifroid Jaifroid added this to the v4.0 milestone Aug 18, 2023
@Jaifroid Jaifroid self-assigned this Aug 18, 2023
@Jaifroid Jaifroid changed the title Unit tests on Firefox sometimes assert in TestCafé before the test has finish (so they fail) Unit tests on Firefox sometimes assert in TestCafé before the test has finished (so they fail) Aug 18, 2023
@Jaifroid
Copy link
Member Author

Probably just need to increase the timeouts and test several times.

@Jaifroid
Copy link
Member Author

Though, this failure is extremely rare. The Selenium-based tests in fact fall over randomly more often. See #1069.

@Jaifroid Jaifroid added bug-non-critical For bugs that it would be nice to fix rather than critical to fix and removed bug labels Sep 5, 2023
@Jaifroid Jaifroid modified the milestones: v3.11, v4.0 Nov 1, 2023
@Jaifroid Jaifroid modified the milestones: v4.0, v4.1 Feb 21, 2024
@Jaifroid
Copy link
Member Author

I don't think we need to fix this. Especially if we move Unit tests to a more standard platform than QUnit. See #1187.

@Jaifroid Jaifroid closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaifroid Jaifroid

Labels
bug-non-critical For bugs that it would be nice to fix rather than critical to fix tests
Projects
None yet
Milestone
v4.1
Development

No branches or pull requests
1 participant
@Jaifroid