Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to major changes in stylesheets and content layout with new mobile html endpoint Wikimedia ZIMs #629

Open
Jaifroid opened this issue Aug 4, 2024 · 3 comments
Assignees
Labels
fixed Fixed, awaiting publication in new apps user interface UI issues waiting for feedback
Milestone

Comments

@Jaifroid
Copy link
Member

Jaifroid commented Aug 4, 2024

The switch in mwOffliner to the new mobile html endpoint means that there are significant layout changes, as well as changes to bundled stylesheets. This has effects in the PWA (and WikiMed / Wikivoyage) apps, because the override stylesheets included to switch between mobile and desktop styles are only partially working. Additionally, override code for fixing the details-summary tags needs to be adapted.

None of this is impossible, but it is time-consuming to adjust.

@Jaifroid Jaifroid added this to the Release 3.5.0 milestone Aug 4, 2024
@Jaifroid Jaifroid self-assigned this Aug 4, 2024
@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 5, 2024

This issue is fixed for Wikivoyage ZIMs with 54c7142 and 2928134. Remaining to do is:

  • Transformation to Desktop style
  • Testing on non-Wikivoyage ZIM types, when we have such ZIMs

@Jaifroid
Copy link
Member Author

Jaifroid commented Aug 5, 2024

Transform to desktop now fixed with eb2222e.

@Jaifroid Jaifroid added waiting for feedback fixed Fixed, awaiting publication in new apps labels Aug 6, 2024
@Jaifroid
Copy link
Member Author

All issues are currently fixed, but we don't have the final format of Wikimedia ZIMs scraped with the mobile-html REST API, so I'll leave open to monitor.

@Jaifroid Jaifroid removed the bug label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed, awaiting publication in new apps user interface UI issues waiting for feedback
Projects
None yet
Development

No branches or pull requests

1 participant