Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for include xml elements inside <manifest><application> AndroidManifest.xml #1519

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dvjdjvu
Copy link

@dvjdjvu dvjdjvu commented Oct 21, 2022

My changes affect builddozer and python-for-kivy.

I added support for add rules for autostart. Now you can use section in buildozer.spec:

android.extra_manifest_application = %(source.dir)s/xml/receivers.xml

updated android.extra_manifest_application to android.extra_manifest_application_entry (see here)

for add rules in AndroidManifest.xml for autostart:

<receiver android:name=".MyBroadcastReceiver" android:enabled="true" android:exported="true">
    <intent-filter>
        <action android:name="android.intent.action.BOOT_COMPLETED" />
        <action android:name="android.intent.action.QUICKBOOT_POWERON" />
        <action android:name="com.htc.intent.action.QUICKBOOT_POWERON" />
    </intent-filter>
</receiver>

This is article doesn't work Starting Kivy App and Service on bootup on Android

Copy link
Contributor

@lufebe16 lufebe16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes locally.

These 2 changes lead to an new attribute in the commanline to python-for-android that looks correctly. (But python-for-android should be tested.)

lufebe16
lufebe16 previously approved these changes Dec 14, 2022
Copy link
Contributor

@lufebe16 lufebe16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changes have been applied. This is o.k. for me.

# support for extra-manifest-application
extra_manifest_application_entry = self.buildozer.config.getdefault(
'app', 'android.extra_manifest_application_entry', '')
if extra_manifest_application:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect variable name here... should be "extra_manifest_application_entry" and not "if extra_manifest_application"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see. Thx.
Updated.
image

js-teevee
js-teevee previously approved these changes Feb 13, 2023
@js-teevee
Copy link

can we get an update on this please? these changes are necessary for services to restart, start on boot etc and will take kivy/python-for-android to the next level and something my company really needs (custom aosp firmware).

@dvjdjvu
Copy link
Author

dvjdjvu commented Sep 25, 2023

Updated the PR to the latest versions of the source code.

@dvjdjvu
Copy link
Author

dvjdjvu commented Sep 25, 2023

@misl6 @lufebe16 @js-teevee, I updated the PR to the latest versions of the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants