-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for include xml elements inside <manifest><application> AndroidManifest.xml #1519
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested these changes locally.
These 2 changes lead to an new attribute in the commanline to python-for-android that looks correctly. (But python-for-android should be tested.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes have been applied. This is o.k. for me.
buildozer/targets/android.py
Outdated
# support for extra-manifest-application | ||
extra_manifest_application_entry = self.buildozer.config.getdefault( | ||
'app', 'android.extra_manifest_application_entry', '') | ||
if extra_manifest_application: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect variable name here... should be "extra_manifest_application_entry" and not "if extra_manifest_application"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we get an update on this please? these changes are necessary for services to restart, start on boot etc and will take kivy/python-for-android to the next level and something my company really needs (custom aosp firmware). |
Updated the PR to the latest versions of the source code. |
@misl6 @lufebe16 @js-teevee, I updated the PR to the latest versions of the source code. |
My changes affect builddozer and python-for-kivy.
I added support for add rules for autostart. Now you can use section in buildozer.spec:
updated android.extra_manifest_application to android.extra_manifest_application_entry (see here)
for add rules in AndroidManifest.xml for autostart:
This is article doesn't work Starting Kivy App and Service on bootup on Android