Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpatialEvent _localize_after_cross_correlation distance_residuals not set #1070

Open
sammlapp opened this issue Oct 22, 2024 · 0 comments
Open

SpatialEvent _localize_after_cross_correlation distance_residuals not set #1070

sammlapp opened this issue Oct 22, 2024 · 0 comments
Labels
bug Something isn't working resolved_in_develop The issue has been resolved in the develop branch but not in master

Comments

@sammlapp
Copy link
Collaborator

The distance_residuals is only calculated if location_estimate is not None,
so you get UnboundLocalError (missing variable) if the location estimate is None when it tries to return distance_residuals

this probably happened during a refactor, should be resolved asap by setting to None if location_estimate is None
@sammlapp sammlapp added the bug Something isn't working label Oct 22, 2024
sammlapp added a commit that referenced this issue Oct 22, 2024
@sammlapp
resolves two bugs in localization
edbfe1c 
- SpatialEvent _localize_after_cross_correlation distance_residuals not set #1070
- SynchronizedRecorderArray.create_candidate_events was not using min_n_receivers or self.speed_of_sound when creating events

adds test for #1070
@sammlapp sammlapp added the resolved_in_develop The issue has been resolved in the develop branch but not in master label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working resolved_in_develop The issue has been resolved in the develop branch but not in master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sammlapp