Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.env options have no effect due to incorrect syntax #114

Open
geloescht opened this issue Oct 28, 2017 · 3 comments
Open

.env options have no effect due to incorrect syntax #114

geloescht opened this issue Oct 28, 2017 · 3 comments

Comments

@geloescht
Copy link

All options set by editing the .env file that is created by default have no effect whatsoever. The reason is, that the environment variables include semicolons at the end of each line. But config/custom-react-scripts/config.js expects the value "false" without a semicolon, thus enabling every single option if it finds "false;" instead.

BTW: webpack-dashboard seems to introduce serious memory leak issues. It took me ages to hunt these down, because I thought I had disabled the dashboard.

@jurosh
Copy link

jurosh commented Nov 27, 2017

Got same performance issues, thanks god for your advice to remove semicolons.. I've created PR (#121) for this, so hope we can hot-fix this critical issue...

@m1n0s
Copy link

m1n0s commented Jan 22, 2018

@geloescht thanks for your attention! 4 node.js processes had been killing my CPU.

tadachi pushed a commit to tadachi/hydra-chat that referenced this issue Feb 14, 2018
Possible fix for create-react-app RAM and CPU Drain
see kitze/custom-react-scripts#114
@amadeogallardo
Copy link

@geloescht I can confirm the same behavior. Disabling Webpack Dashboard fixed the performance overhead issues and improved the hot reloading times considerably.

The tradeoff was actually having to turn the AC heater on, instead of just using my notebook as a heater by frequently triggering a file change. In this case, it was quite literally a "hot reload".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants