-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.env options have no effect due to incorrect syntax #114
Comments
Got same performance issues, thanks god for your advice to remove semicolons.. I've created PR (#121) for this, so hope we can hot-fix this critical issue... |
@geloescht thanks for your attention! 4 node.js processes had been killing my CPU. |
Possible fix for create-react-app RAM and CPU Drain see kitze/custom-react-scripts#114
@geloescht I can confirm the same behavior. Disabling Webpack Dashboard fixed the performance overhead issues and improved the hot reloading times considerably. The tradeoff was actually having to turn the AC heater on, instead of just using my notebook as a heater by frequently triggering a file change. In this case, it was quite literally a "hot reload". |
All options set by editing the .env file that is created by default have no effect whatsoever. The reason is, that the environment variables include semicolons at the end of each line. But config/custom-react-scripts/config.js expects the value "false" without a semicolon, thus enabling every single option if it finds "false;" instead.
BTW: webpack-dashboard seems to introduce serious memory leak issues. It took me ages to hunt these down, because I thought I had disabled the dashboard.
The text was updated successfully, but these errors were encountered: