Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slider block and update event content type #34 #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add slider block and update event content type #34 #35

wants to merge 1 commit into from

Conversation

iFlameing
Copy link
Member

No description provided.

@iFlameing iFlameing force-pushed the update-event-slider branch from dac31a3 to c0f9c75 Compare June 6, 2024 10:41
@iFlameing iFlameing changed the title Update event and add slider block Add slider block and update event content type #34 Jun 6, 2024
@iFlameing iFlameing mentioned this pull request Jun 6, 2024
Closed
@iFlameing iFlameing requested review from davisagli and ericof June 10, 2024 11:18
davisagli
davisagli approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay but it's hard to review because of how some of the items get reordered in the collective.exportimport format. Let's please convert it to plone.exportimport before doing more work on this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@ericof ericof Awaiting requested review from ericof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iFlameing @davisagli