Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add person search #6

Open
20 of 22 tasks
steffenri opened this issue Nov 9, 2023 · 5 comments
Open
20 of 22 tasks

Add person search #6

steffenri opened this issue Nov 9, 2023 · 5 comments
Assignees

Comments

@steffenri
Copy link
Member

steffenri commented Nov 9, 2023

Prerequisites

Specification

  • Add new Search UI for member search
  • Add new facets (currently the collective.person package only has the absolut basic information https://github.com/collective/collective.person/blob/main/src/collective/person/behaviors/person.py)
    • Institute
    • Building
    • Room
    • Skills
  • Use Fallback-Avatar in case no profile picture is available
  • Implement new design (see below)
  • Information that should be displayed on the search results: (Most of them need to be added to collective.person first or added as a customization in kitconcept.intranet)
    • URL (relative path)
    • First and last name
    • Skills
    • Phone
    • Building/Room
    • E-Mail
  • Add option to switch between listing and grid view (see Design)
  • Add option to search by:
    • Relevance
    • Alphabet (Lastname or Title)
  • Add pagination

Figma

https://www.figma.com/file/eYUCbivnNrnjXjBDUizSVX/Volto-Light-Theme?type=design&node-id=343-6729&mode=design&t=P4IU8MuYCbBQJk0v-0

Screenshot Listing View

intranet-profile-search_grid-with-image (1)

Screenshot Grid View

intranet-profile-search_grid-with-image (2)

@steffenri
Copy link
Member Author

steffenri commented Nov 9, 2023

@tisto @sneridagh Are those the correct designs? I was not quite sure which one to use from the VLT.

Also: The collective.person package contains only the most basic information at the moment (https://github.com/collective/collective.person/blob/main/src/collective/person/behaviors/person.py#L34). Do we want to add things like phone,mail, etc. to the package or customize it on our side?

@reekitconcept reekitconcept self-assigned this Nov 27, 2023
@tisto
Copy link
Member

tisto commented Dec 12, 2023

@steffenri @reekitconcept I'd start with a basic version that hard-codes the available facets.

Can you provide the schema for the collective.person profile? I'd like to have a basic person profile and 2-3 basic facets (that we have in all our intranet projects), e.g.:

  • Institute
  • Building
  • Room
  • Skills

I see the kitconcept.intranet person search as a showcase for our basic functionality. We always need to override this for client projects (like BfS) for the time being.

Making the facets fully configurable and maybe even addable/editable TTW is something we can tackle at a later point.

@reekitconcept
Copy link
Member

reekitconcept commented Dec 12, 2023

I'm already over 50% progress with this. I agree that the facet configuration should be basic and focusing on this use case first.

TTW is not targeted under this ticket. The configuration is json and done via plone.app.registry, in the same way the search and the facets are configured but extending it. kitconcept.solr comes with sensible defaults oob, which can be overridden by the consumer. To stress out there is nothing new here, I just extend what we already use with success with kitconcept.solr.

Regarding "providing the collective person profile". What I'm doing currently is that I'm creating the collective.person profile and the facet configuration together. Once they are working according to the specification described in the ticket, I can finalize it as a PR in kitconcept.intranet. @tisto if this approach is not you have in mind, let's discuss this please!

Also note that how the final configuration in the consumer app is to be done is still unclear and we're waiting for Erico's proposal about the new dual client/server configuration scheme, for which this application will be the first user of. If Erico's proposal is however arriving later then we like, we are not depending on Erico and release as a separate packages for client and server. It's just important to stress that we are not intending to solve the dual client/server configuration under this work, rather than use something that we'll use for everything.

@tisto
Copy link
Member

tisto commented Feb 28, 2024

Things we need to do to push this further:

  • set up BfS intranet dev instance with Solr
  • set up plone-intranet.kitconcept.com dev instance for kitconcept.intranet with Solr
  • do full QA on the search/person search on kitconcept intranet dev instance
  • polish the vanilla search/person search on kitconcept intranet dev instance
  • have a discussion regarding plone distribution and dependencies with the team

@tisto
Copy link
Member

tisto commented Feb 28, 2024

@ericof could you look into either:

  • set up solr on bfs intranet instance or
  • set up plone-intranet.kitconcept.com from scratch with the kitconcept.intranet distribution and Solr

start with whatever is faster to have something up and running we can work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants