Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group (Autograder) Annotations by Type #16

Open
Luro02 opened this issue May 6, 2024 · 3 comments · May be fixed by #90
Open

Group (Autograder) Annotations by Type #16

Luro02 opened this issue May 6, 2024 · 3 comments · May be fixed by #90
Assignees

Comments

@Luro02
Copy link
Collaborator

Luro02 commented May 6, 2024

There can be a lot of annotations and it becomes harder to have an overview/give sensible feedback.

The current Autograder implementation reduces the annotations before emitting it to the grading tool. Because of this the not emitted annotations will not be looked over by the grading tool user.

It seems sensible to have some sort of group like a collapsible and make intelligrade merge the final annotations (alternatively this could be done by Artemis4J)

@dfuchss
Copy link
Member

dfuchss commented Sep 26, 2024

@Luro02 this is fixed now with kit-sdq/artemis4j#117 , right :) ?

@Luro02
Copy link
Collaborator Author

Luro02 commented Sep 27, 2024

@Luro02 this is fixed now with kit-sdq/artemis4j#117 , right :) ?

No, this is something different. Artemis4J groups all annotations for the student, but one of the reasons why I implemented the merging in the first place (in the autograder), was that tutors were overwhelmed with the number of annotations in the annotation list.

Merging them before the tutor went through them, is a bad solution, because of how much work it would be to figure out false-positives/remove them from the merged annotation. (That one is important for me, I likely have missed many false-positives, because of this)

This issue suggests adding a collapsible entry in the annotation list, that groups the annotations (like artemis4j does).

I am thinking of something like this:

v Custom Comment | L5, L10, ... |               | AUTOGRADER | Here the merged message, other problems in (L10, L11, ...)
Custom Comment   | L5           | src/Main.java | AUTOGRADER | Some message
Custom Comment   | L10          | src/Main.java | AUTOGRADER | Some message
Custom Comment   | L11          | src/Main.java | AUTOGRADER | Some message

Where you can press on the row with a "v" to show all messages that are merged with it. By collapsible rows, I am thinking of something like this:
https://stackoverflow.com/a/9517974/7766117

@Luro02
Copy link
Collaborator Author

Luro02 commented Sep 27, 2024

I was planning to investigate this myself, but I haven't had the time to do this yet. This issue will likely need another Artemis4J PR to expose some of the stuff that I implemented in the merging PR

@Luro02 Luro02 self-assigned this Dec 19, 2024
@Luro02 Luro02 linked a pull request Dec 22, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants