Note cache

[jorilallo]

There are cases when notes isn't cleared when moving between urls.

[d2s]

Have seen this from time to time. Gets little bit distracting when one can't add new note for another website since the old one just keeps on dragging.

But fortunately, it's not happening that often. As a (bit painful) workaround, browser restart seems to help.

[jorilallo]

If I remember correctly, it shows up when you have added some notes, so the title won't clear but is fetched from the cache instead. Same applies for Safari

[d2s]

Haven't used Safari that much (even less with Kippt) but got weak signal on my head that problem could be partially caused by the situation where you have multiple tabs and start to write note about page in one tab (without saving it), move to another and try to add note about another. After that, problem could be visible for "some time". Not sure about the theory, thought.

[amckinlay]

The issue is that the extension's popup uses localStorage to cache unsaved fields. However, localStorage is global to the extension, and does not differ based on the tab the popup is activated in. LocalStorage is only cleared when a clip is saved, leading to the bug. I don't know what the goal of saving popup state is...maybe to avoid loss of form data if the popup is accidentally closed? Unfortunately, Google offers no easy solution. Perhaps:

• Persist state in background page's DOM
• Persist state in injected script using DOM or sessionStore (easier)

Unfortunately, Chrome's extension API closes the popup's window, so sessionStore cannot be used from within the popup.

[jorilallo]

It's quite common that people close the extension accidentally and lose their notes. This feature was added to combat that.

As we're now thinking of making the extension with in-page injection, it would make sense to move to sessionStore. With in-page injection the underlying problem also disappears so it might make sense to remove the feature altogether.