Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Disconnect (by choice!) #2

Open
killnine opened this issue Aug 29, 2014 · 1 comment
Open

Client Disconnect (by choice!) #2

killnine opened this issue Aug 29, 2014 · 1 comment
Labels
enhancement help wanted

Comments

@killnine
Copy link
Owner

As of 1.0.2, the Manager will always try and reconnect any time that it detects the Closed event. Probably need to prevent this. Users may want to eventually disconnect ;)
@jamiehumphries
Copy link
Contributor

How about just adding a Stop() method to IHubConnectionManager, which could remove all of the event listeners then stop the connection. I'd also recommend that IHubConnectionManager extended IDisposable and that Dispose() called through to the new Stop() method.

I can add that in if you think that is a reasonable way to achieve this.

@jamiehumphries jamiehumphries mentioned this issue Dec 18, 2014
Merged
killnine added a commit that referenced this issue Dec 20, 2014
@killnine
Merge pull request #8 from jamiehumphries/2-stop-connection
f53d9cf 
#2 Clients can stop connection without triggering restart attempt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@killnine @jamiehumphries