Proxmox patch submission

[brunokc]

Hello,

Thank you for putting this together. I haven't been able to do any in-depth testing, but applying it allows me to pass-through an HBA that I wasn't able to use on a VM before. I liked it enough to put together an PVE kernel builder with this patch to spit out builds as they get released by Proxmox.

Before I found this patch, I had reached out to Proxmox asking them to look into this issue. After I found your patch, I let them know about it and suggested they just make it part of Proxmox proper. They seem to have agreed, but they're requesting that the author submits the patch according to their Developer documentation. You can see my exchange with them on the ticket I opened. Would you be willing to submit it?

Thanks!

[brunokc]

@kiler129, checking in to see if you'll be able to submit your patches to Proxmox. Please see above for a link to the ticket current open on this.

[brunokc]

@kiler129, I'm making one last attempt to reach you. Please consider contributing your patch to Proxmox. If you can't do it yourself for whatever reason (no explanation needed), please consider giving me permission so I can follow Proxmox's guidelines and get it integrated into their kernel.

Thank you!

[Arszilla]

@kiler129 It'd be sincerely appreciated if we could get your approval in that thread that @brunokc created in Proxmox, so we can get this patch applied to the Proxmox kernel. It'd be great to have the kernel patched so that no one will have to depend on finding Debian packages, building the patches themselves, etc.

[jbtronics]

As far as I see, the main problem here is that proxmox seems to require the permission of the original code owner to include their code. I dont understand completly why, because the GPL dont require that at all, but I guess only the copyright owner can sign the CLA agreement.

However, the actual patch is pretty simple, basically just 5 lines of code which utilize already existing mechanisms in the linux kernel (and therefore is not even very innovative or creative). I guess one could even argue if such a trivial thing even falls under copyright law, as it maybe not reach the threshold of copyrightability .

It should not be much work to write your own implementation of this patch, especially if you will most likely need to rewrite it in a way, that you can integrate it into the kernel builder.
So I would suggest that @brunokc just writes its own implementation of the principle. As long as it just uses the same idea (which is itself not part to copyright), and not the original code by @kiler129, then that should be fine from a copyright point of view and there should be no problem to integrate it into proxmox.
(Disclaimer: I'm not a lawyer)

[Fabian-Gruenbichler]

FWIW, the next proxmox-kernel bump (> 6.2.16-12) will contain this patch, hopefully making this repo obsolete for systems running up to date Proxmox products.

[brunokc]

Thank you, @Fabian-Gruenbichler !

[breadlysm]

I just upgraded proxmox from 7.4 to 8.1.4, it upgraded the kernel to 6.5 and I did not have to repatch the kernel. Thank you @Fabian-Gruenbichler