-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working on heroku #10
Comments
Q: was there any other info? Dont know what's ailing, so likely need to debug with heroku. Perhaps some needed gem is not installed in production? Check Gemfile. Also try running assets compile task locally using "RAILS_ENV=production bundle exec rake ..." |
@aesnyder did you verify that you use the exact version of ngannotate-rails (and ng-annotate) on your local machine as well as heroku? |
I'm closing this because I'm an idiot, everything is working now. Sorry! |
Encountered the same problem, @aesnyder how did you resolve it? |
@aesnyder @Haihappen I'm getting this issue on heroku myself. If this is resolved, can you please explain what the issue was and how to fix it? |
@aesnyder if you've some info regarding issue, I would love to have it mentioned in project README, since clearly there is something which is tripping over several people. Alternatively: Anyone, do you've some failing sample test app what I could look into to investigate issue? |
@kikonen My team actually gave up attempting to get this module to work and instead switched to turning the When following the steps to test locally I was able to confirm that the rendered javascript was not being annotated at all by ngannotate-rails, but wasn't able to locate the source of the issue. Unfortunately the project in question is client related so I can't hand over the source, but I can fire up a new rails project later today for testing and make that available. |
If there is some case which is not handled you should be in contact with KI
|
This may be related |
So I'm completely kicking myself for not having answered this, as I just spent another few hours on it today....
When pushing to heroku its important to invalidate all of your assets. |
TODO:
(just re-opening so that I will remember to add note into README) |
Addressed README via #23 |
Did someone find out what's happening with heroku? Invalidate all assets is not always an option, since then all assets needs to be recompiled from scratch and it takes lot of time. Also one have to remember to invalidate them by changing value of |
I haven't myself spend time to investigate Heroku, since I don't right now have suitable env in Heroku for trying it out. But I hear you, clearly some digging is needed. |
To make asset versioning easier in the meantime you could set an ENV variable like (taken from thoughtbot's suspenders): |
We might be able to optionally use a random |
Not working on dokku either. Even after cleaning the cache and bumping the assets version. Moved to #26 |
Maybe you can try using the dyno-metadata labs to use the
and set
|
I'm noticing that this works fine locally but on heroku I'm getting a failed to instantiate module due to unknown provider: e -- any ideas?
The text was updated successfully, but these errors were encountered: