Sho/docker #86
Merged
Sho/docker #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…~arl/elkweb-docker
updated names
Using docker-compose's feature to check wether the server is still running from inside the container.
Since the process inside the container eats up all the server resources and we don't know why, limiting the available resources to mitigate the problem seems a legit idea. The container might use half a CPU and 512 MB of memory.
Avoiding local cache data as well.
No need to copy docker-compose.yml into Docker image.
There was a git command-line call when yarn builds webpack components of the client. This fails in some build environemnts (e.g. Github build actions or standard Docker builds) when no .git/ folder is found in project root.
We already have a version information declared in package.json for NPM description. Use it to render in web pages instead of hard coded string or plain git commit hash. Later on, the version information might get bumped when building releases and reused to set tags in git and to Docker images.
When a commit hash is provided via GitHub's build action environment variable it's concatinated to the version string rendered to web pages.
It's easier to read.
Group ID of non-privileged user can now also be passed from outside via Docker argument. This is beneficial when binding your work directory to actively develop the app using a running container instance. By setting matching file permission inside container environment you avoid mixing up file permission between both sides of the mounted folder.
Defaulting to dynamically assigned host port which eases starting multiple container (instances). Add an environment option to specify host port explicitly, e.g. for production environment.
Forcing the user to copy the file and activate relevant lines by removing leading hash character.
Some build time dependency caches that should be ignored from version control and from being copied back into container image as well.
Comment out volumes section to leave it as option for local development.
This is the default UID:GID mapping now as the previously hard-coded values of 1002:1002 where used in production system, only.
When building locally a 'latest' tag is added to each new image. As it seems, this is done automatically only for tagged releases in GitHub Actions. Let's try setting this tag explicitly as it's the default tag for a image specification when no other is given.
This reverts commit 6702560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in and adapt Docker and
docker-composefiles from production environment, preserving history.