Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove getNearbyPOIs / ...Vehicles #114

Closed
Kebslock opened this issue Aug 31, 2023 · 1 comment
Closed

Remove getNearbyPOIs / ...Vehicles #114

Kebslock opened this issue Aug 31, 2023 · 1 comment
Assignees
@Kebslock
Labels
backend

Comments

@Kebslock
Copy link
Contributor

The functions getNearbyPOIs and getNearbyVehicles, which can be found in the POI- and vehicle-service respectively, are way too complex and difficult to use as well as not much used at all. The POI variant is not even called and can probably just be deleted. The vehicle variant needs some refactoring as it gets called, but in a very simple way, so that just all vehicles for the same track are returned. This needs to be inspected and adapted, but overall both functions should be removed.
@Kebslock Kebslock self-assigned this Aug 31, 2023
This was referenced Aug 31, 2023
Merged
Closed
@Kebslock
Copy link
Contributor Author

Kebslock commented Sep 4, 2023

getNearbyPOIs got already deleted after cleaning up the services (after PR #113). getNearbyVehicles needs still to be handled.

Kebslock pushed a commit that referenced this issue Sep 7, 2023
#114: Replaced getNearbyVehicles
2585101
Kebslock pushed a commit that referenced this issue Sep 7, 2023
Revert "#114: Replaced getNearbyVehicles"
9ea016d 
This reverts commit 2585101.
Kebslock pushed a commit that referenced this issue Sep 7, 2023
#114: Replaced getNearbyVehicles
8d06ad0
@Kebslock Kebslock mentioned this issue Sep 7, 2023
Merged
JulianGrabitzky added a commit that referenced this issue Sep 7, 2023
@JulianGrabitzky
Merge pull request #140 from kieler/114-remove-getnearbypois-vehicles
d092441 
#114: Replaced getNearbyVehicles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kebslock Kebslock

Labels
backend
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

114-remove-getnearbypois-vehicles kieler/RailTrail
2 participants
@JulianGrabitzky @Kebslock