Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update functions in services #102

Closed
Kebslock opened this issue Aug 27, 2023 · 1 comment
Closed

Update functions in services #102

Kebslock opened this issue Aug 27, 2023 · 1 comment
Assignees
Labels

Comments

@Kebslock
Copy link
Contributor

Currently there are several functions in each service updating the related models e.g. setting start and end point of a track and updating the GeoJSON-path (one function for each). This is not a good design as the database has just one function to update for each model and also the frontend sends all updated data at once. If there is any business logic to do, the API / routes handling needs to handle each sent value from the frontend independently and call one service function for each.

So all update functions on service level should be aggregated to one function per model. A workaround is to do the business logic in the API (see #89 for example).

@Kebslock
Copy link
Contributor Author

This issue will be resolved by #113.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant