Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report skipped entities with warning log level #650

Open
Christina-J-Diaz opened this issue Nov 1, 2022 · 1 comment
Open

Report skipped entities with warning log level #650

Christina-J-Diaz opened this issue Nov 1, 2022 · 1 comment
Labels
refactor Something needs to be done better usability issues

Comments

@Christina-J-Diaz
Copy link

When values are missing from an entity and skip the loading stage, no warning sign is displayed. You can use debug mode to see which records are being skipped, but the message is misleading:

2022-11-01 12:49:00,975 - LoadStage - Thread: MainThread - DEBUG - Skip phenotype. Missing key components. Failed to construct unique key from record:
{'PARTICIPANT|ID': '28652',
 'PHENOTYPE|EVENT_AGE_DAYS': '0.6598220397',
 'PHENOTYPE|NAME': 'macroglossia',
 'PHENOTYPE|OBSERVED': 'Reported Unknown',
 'PROJECT|ID': 'SD_PREASA7S'}

The above record was skipped because PHENOTYPE.EVENT_AGE_DAYS is of type float when it should be of type int. A warning log should be added to clearly state the reason why these records skipped loading.

@znatty22 znatty22 added refactor Something needs to be done better usability issues labels Nov 1, 2022
@znatty22
Copy link
Member

znatty22 commented Nov 1, 2022

This

above record was skipped because PHENOTYPE.EVENT_AGE_DAYS is of type float when it should be of type int

is due to a bug that will be fixed in #649.

I do like the idea of reporting skipped entities with the warning log level tho 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something needs to be done better usability issues
Projects
None yet
Development

No branches or pull requests

2 participants