fix(linux): Correctly open files linked from help page #9601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around the issue where browsers installed as snap package can't access files under `$HOME/.local`. Instead we now only open external links with the browser. Local non-html files we open with the default app, and links to local html file we open in webview (like we did previously with `welcome.htm` files). Fixes #9600.
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Test Artifacts
|
Test Results
..in Ubuntu 22.04 Jammy Linux 
..in Ubuntu 23.04 Lunar Linux 
|
keymanapp-test-bot
bot
removed
the
user-test-required
|
Changes in this pull request will be available for download in Keyman version 17.0.178-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the issue where browsers installed as snap package can't access files under
$HOME/.local. Instead we now only open external links with the browser. Local non-html files we open with the default app, and links to local html file we open in webview (like we did previously withwelcome.htmfiles).Fixes #9600.
User Testing
TEST_LOCALLINK: follow the test steps in #9600 and verify that the "Font license" and "Font documentation" files are displayed.