Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linux): rename test files #12706

Merged
merged 2 commits into from
Nov 27, 2024
Merged

chore(linux): rename test files #12706

merged 2 commits into from
Nov 27, 2024

Conversation

ermshiperete
Copy link
Contributor

@ermshiperete ermshiperete commented Nov 26, 2024

This change rename the test files for Linux according to the discussion at the Keyman conference in November 2024.

Python is pretty opinionated about the naming of files, so we have to use *_tests.py as test filename instead of the usual *.tests.py.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Nov 26, 2024

User Test Results

Test specification and instructions

User tests are not required

This change rename the test files for Linux according to the discussion
at the Keyman conference in November 2024.

Python is pretty opinionated about the naming of files, so we have to
use `*_tests.py` as test filename instead of the usual `*.tests.py`.
@ermshiperete ermshiperete force-pushed the chore/linux/rename-tests branch from 9953584 to 4a852c9 Compare November 26, 2024 18:06
@ermshiperete ermshiperete marked this pull request as ready for review November 26, 2024 18:31
@darcywong00
Copy link
Contributor

Can we also update some of the Linux readmes?

https://github.com/keymanapp/keyman/tree/master/docs/linux#testing

  • Maybe include a note about the test filename convention

"-p", "test_*.py"

  • Does the sample VS Code config file update?

Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the docs label Nov 27, 2024
@ermshiperete ermshiperete merged commit 06cd709 into master Nov 27, 2024
3 checks passed
@ermshiperete ermshiperete deleted the chore/linux/rename-tests branch November 27, 2024 09:17
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.146-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants