test(common/web/types): unit tests for string-list #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
|
Hmm ... I have been happily typing |
…052-unit-tests-string-list
|
Ready for review ... as this has largely been done in a single day following a context switch from C++, please check carefully. |
mcdurdin
approved these changes
Nov 27, 2024
| @@ -0,0 +1,207 @@ | |||
| import 'mocha'; | |||
There was a problem hiding this comment.
Let's add the standard header https://github.com/keymanapp/keyman/wiki/Keyman-Code-Style-Guide#file-header
Comment on lines
204
to
205
| for (const s of source) | ||
| listItem.push(new ListIndex(new StrsItem(s))); |
There was a problem hiding this comment.
Suggested change
| for (const s of source) | |
| listItem.push(new ListIndex(new StrsItem(s))); | |
| for (const s of source) { | |
| listItem.push(new ListIndex(new StrsItem(s))); | |
| } |
Per style guide once more ("Always use braces and always on a new line")
markcsinclair
deleted the
test/common/web/types/9052-unit-tests-string-list
branch
|
Changes in this pull request will be available for download in Keyman version 18.0.147-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for `ldml-keyboard/string-list.ts'
See #9052
@keymanapp-test-bot skip