Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Consider long-press default key (i.e. when user long-presses but doesn't swipe) as dev-configurable 🐵 #9416

Closed
1 of 2 tasks
Tracked by #5029
mcdurdin opened this issue Aug 4, 2023 · 3 comments

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Aug 4, 2023

gestures/longpress

From a UI perspective, it would be nice to have a longpress that is automatically selected rather than having to move up off the base key to select a key. The default should be highlighted in the longpress menu when the menu appears. I think any macro movement after that would then return to traditional longpress behaviour.

The keyboard designer needs to be able to select the default longpress key, or to have no default. (The fallback behaviour for existing keyboards should probably be no default?)

Requires:

@jahorton do you think it is possible to include this in gestures-17.0?

This comes out of a design discussion in 16.0, missed getting an issue assigned at the time.

Note from #8519:

  • Default will be selectable by keyboard designer -- not necessarily the first, and may be none.
  • Where there is a default will be indicated by highlighting it in the longpress -- the normal selection highlight.
  • Given that cancel is not the preferred default action for a longpress, the user can cancel the longpress default by sliding outside the 'acceptance' area -- e.g. south of the key cap, which would then unhighlight the default and indicate visually that no output would occur when they release their finger.
@jahorton
Copy link
Contributor

jahorton commented Aug 4, 2023

Yeah, sure. I'd love to have that included. I loved when that "unintended feature" was active. (Where we auto-selected the first subkey)

@mcdurdin mcdurdin added this to the A17S19 milestone Aug 8, 2023
@keymanapp-test-bot keymanapp-test-bot bot changed the title feat: Consider long-press default key (i.e. when user long-presses but doesn't swipe) as dev-configurable feat: Consider long-press default key (i.e. when user long-presses but doesn't swipe) as dev-configurable 🐵 Aug 8, 2023
@mcdurdin mcdurdin modified the milestones: A17S19, A17S20 Aug 18, 2023
@darcywong00
Copy link
Contributor

I think #9496 addresses the KeymanWeb portion of this.

@mcdurdin mcdurdin modified the milestones: A17S20, A17S21 Sep 1, 2023
@mcdurdin mcdurdin modified the milestones: A17S21, A17S22 Sep 15, 2023
@mcdurdin mcdurdin modified the milestones: A17S22, A17S23 Oct 1, 2023
@mcdurdin mcdurdin modified the milestones: A17S23, A17S24 Oct 15, 2023
@jahorton
Copy link
Contributor

#9496 + #9698 ensure that this will be handled, both before and after the gesture-engine rework. I'm going ahead and closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants