Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove QIT_VKEYDOWN, QIT_VKEYUP, QIT_VSHIFTDOWN, QIT_VSHIFTUP #10049

Closed
mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10060
Closed

chore(core): remove QIT_VKEYDOWN, QIT_VKEYUP, QIT_VSHIFTDOWN, QIT_VSHIFTUP #10049

mcdurdin opened this issue Nov 22, 2023 · 0 comments · Fixed by #10060
Labels
chore core/ Keyman Core
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Nov 22, 2023

These four actions have never been officially supported, have only ever sorta worked on Windows (race conditions galore), and only one keyboard in the keyboard catalogue attempts to use them (gandhari, emitting () and then K_LEFT); bu_phonetic has some strange no-op kinda rules with them which would need correcting.

So:

  1. Remove them (and fixup subsequent compile errors in keyboards repo)
  2. Update compiler to error on VKEY out in all cases (see chore(developer): add warning or error if virtual key used in output of rule #10059)
  3. Update documentation which hints at support on Windows.

This simplifies the #9999 action queue <--> struct work.

Identified while preparing for #10052.

Note that Windows continues to use these identifiers internally in keyman32, and has its own separate header file declaring them. Don't change this at this time.

@keymanapp-test-bot keymanapp-test-bot bot added chore core/ Keyman Core labels Nov 22, 2023
mcdurdin added a commit that referenced this issue Nov 23, 2023
Fixes #10049.

vkey output was never supported by Core, so this code effectively was a
no-op.
@mcdurdin mcdurdin linked a pull request Nov 23, 2023 that will close this issue
@mcdurdin mcdurdin added this to the A17S26 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore core/ Keyman Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant