Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Keycloak CRD should allow for customizing liveness/readiness probes #419

Closed
NickG22293 opened this issue Dec 16, 2021 · 4 comments
Closed

Comments

@NickG22293
Copy link

NickG22293 commented Dec 16, 2021

Description

Change the Keycloak CRD and associated constructs to take in parameters defining different healthcheck criteria for liveness/readiness. Could be just a change to the failureThreshold, or the initialDelaySeconds, or a redefinition of what constitutes the health checks themselves.

Discussion

No response

Motivation

Deploying a Keycloak instance via the operator in a resource-constrained environment can lead to Kubernetes killing and restarting the deployment due to failing liveness probes, as it takes longer for the keycloak server to actually bootstrap (I imagine CPU throttling being the underlying cause in our case). Being able to extend or modify those health checks would allow for Keycloak deployment in a wider variety of environments.

Details

I believe this will be a simple change to the CRD, and the const values defined in the accompanying KeycloakDeployment code in Go.

@NickG22293
Copy link
Author

I'd be happy to start working on an implementation if this concept is considered worthy of implementing.

@andreaTP
Copy link
Contributor

Hi @NickG22293 ,
I do understand that the feature you are requesting is possibly useful, although we are currently planning to completely re-write the operator:
keycloak/keycloak-community#330

I encourage you to ask for this feature in the upcoming operator, for now I close this issue, feel free to re-open it or continue the discussion 🙂

@vmuzikar
Copy link
Contributor

vmuzikar commented Jan 3, 2022

@NickG22293 It is actually possible to use a custom scripts for liveness and readiness checks. All you need to do is to overwrite the default keycloak-probes ConfigMap, the operator won't overwrite it back to its default values.

However, the thresholds etc. are hardcoded and unconfigurable.

@Kampe
Copy link
Contributor

Kampe commented Jan 19, 2022

Please reopen and fix this, keycloak can't even boot with current configurations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants