Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnxruntime starts to provide CMake config for downstream consumption #578

Closed
tmadlener opened this issue Apr 10, 2024 · 1 comment
Closed

Comments

@tmadlener
Copy link
Contributor

Somewhere between version 1.15.0 and 1.17.1 onnxruntime started to install CMake configuration files that make it more easily consumable for downstream packages. It should then be possible to simply do find_package(onnxruntime) and then use targets from there.

Several packages link against onnxruntime already now, e.g. FCCAnalyses and ddfastshowerml, but they come with hand rolled CMake find modules to detect onnxruntime. Unfortunately they do this with different spellings, e.g. OnnxRuntime.

Ideally we switch to a newer version of onnxruntime and simply switch all of our packages to use the available targets from the exported configuration. Unfortunately, it is probably not easily possible to transparently support all versions of onnxruntime easily.

@jmcarcell
Copy link
Member

See some pull requests to support this: HEP-FCC/FCCAnalyses#381, HEP-FCC/k4RecCalorimeter#104. Closing as it seems to be completed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants