From da375fad0c36117994e22a7afd4d310a48338e3e Mon Sep 17 00:00:00 2001
From: Giovanni Marchiori <39376142+giovannimarchiori@users.noreply.github.com>
Date: Thu, 25 Jul 2024 20:22:17 +0200
Subject: [PATCH] harmonise two noise tool interfaces (#214)

* harmonise naming with ICaloReadCellNoiseMap

* fix pre-commit test error

* implement comments from review
---
 k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h | 4 ++--
 k4Interface/include/k4Interface/INoiseCaloCellsTool.h   | 2 +-
 k4Interface/include/k4Interface/INoiseConstTool.h       | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h b/k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h
index 18dc9807..c254efc9 100644
--- a/k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h
+++ b/k4Interface/include/k4Interface/ICaloReadCellNoiseMap.h
@@ -24,7 +24,7 @@
 
 /** @class ICaloReadCellNoiseMap RecInterface/RecInterface/ICaloReadCellNoiseMap.h ICaloReadCellNoiseMap.h
  *
- *  Abstarct Interface to noise per Calorimeter cell.
+ *  Abstract interface for tools that read noise values (RMS and offset) per calorimeter cell
  *
  *  @author Coralie Neubueser
  */
@@ -36,4 +36,4 @@ class ICaloReadCellNoiseMap : virtual public IAlgTool {
   virtual double noiseRMS(uint64_t aCellId)    = 0;
   virtual double noiseOffset(uint64_t aCellId) = 0;
 };
-#endif /* RECINTERFACE_ICALOREADNEIGHBOURSMAP_H */
+#endif /* RECINTERFACE_ICALOREADCELLNOISEMAP_H */
diff --git a/k4Interface/include/k4Interface/INoiseCaloCellsTool.h b/k4Interface/include/k4Interface/INoiseCaloCellsTool.h
index fb1192ae..7f208d54 100644
--- a/k4Interface/include/k4Interface/INoiseCaloCellsTool.h
+++ b/k4Interface/include/k4Interface/INoiseCaloCellsTool.h
@@ -24,7 +24,7 @@
 
 /** @class INoiseCaloCellsTool
  *
- *  Abstract interface to calorimeter noise tool
+ *  Abstract interface for tools that add or filter noise to calorimeter cells
  *
  *  @author Jana Faltova
  *  @date   2016-09
diff --git a/k4Interface/include/k4Interface/INoiseConstTool.h b/k4Interface/include/k4Interface/INoiseConstTool.h
index 09908b6c..fa5b36f9 100644
--- a/k4Interface/include/k4Interface/INoiseConstTool.h
+++ b/k4Interface/include/k4Interface/INoiseConstTool.h
@@ -24,7 +24,7 @@
 
 /** @class INoiseConstTool
  *
- *  Abstract interface to get calorimeter noise per cell tool
+ *  Abstract interface for tools that return noise values (RMS and offset) per calorimeter cell
  *  @author Coralie Neubueser
  *  @date   2018-01
  */
@@ -33,8 +33,8 @@ class INoiseConstTool : virtual public IAlgTool {
 public:
   DeclareInterfaceID(INoiseConstTool, 1, 0);
 
-  virtual double getNoiseConstantPerCell(uint64_t aCellID) = 0;
-  virtual double getNoiseOffsetPerCell(uint64_t aCellID)   = 0;
+  virtual double getNoiseRMSPerCell(uint64_t aCellID)    = 0;
+  virtual double getNoiseOffsetPerCell(uint64_t aCellID) = 0;
 };
 
 #endif /* RECINTERFACE_INOISECONSTTOOL_H */