Build for electron 1.6.0

[mkazlauskas]

Title says it all, would be really useful.

The release is currently at beta.

[davidcraddock]

yes please

[akerbergmika]

+1.

[kirilpopov]

• 1

[dev0tion]

Yes please!

[thomascayne]

This would be great. I'm stuck using Electron 1.4.4 because Electron Edge (EE) is not upgraded. Without EE the entire program is pointless. Unless I find an alternative. Any ideas anyone?

[mkazlauskas]

I ended up using original edge (not electron-edge). I don't know how edge is built but it seems to be working fine using the same node version as documented by edge.

[pmoleri]

Hi @mkazlauskas,

I tried installing [email protected] (node 7.4.0) and [email protected].
Build for node 7.4.0 node_modules\edge\tools\build.bat release "7.4.0".
From inside electron require("edge") throw this error:

Uncaught Error: The specified procedure could not be found.
\\?\C:\...\node_modules\edge\build\Release\edge_nativeclr.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:173:20)
    at Object.Module._extensions..node (module.js:598:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:173:20)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\...\node_modules\edge\lib\edge.js:57:8)
    at Object.<anonymous> (C:\...\node_modules\edge\lib\edge.js:177:3)

The file exists, so I guess the built file for node 7.4.0 isn't compatible with electron 1.6.2.

Is it still working for you?

[kexplo]

It needs edge.js which supports node.js v7.0.
Please track edge's issue.

[pmoleri]

Hi @kexplo
I successfully built electron-edge for 1.6.2 on Windows 10 and seems to be working fine.

1. edit node_modules\electron-edge\tools\build.bat update --target=1.6.2.
2. run build: node_modules\electron-edge\tools\build.bat release "7.4.0"

For anyone else wanting to build, it's important to configure node-gyp correctly.

[kexplo]

OMG!!
The problem is outdated node-gyp!
After upgrading node-gyp, the build succeeded!
Thank you @pmoleri

[kexplo]

I just released new version of electron-edge to npm

[SeanSnyders]

@kexplo It seems that electron-edge 6.5.5 is build for NODE_MODULE_VERSION 51 where electron 1.6.x is running NODE_MODULE_VERSION 53. as per their release notes:

I get this error when trying to launch my electron app on OSX:

App threw an error during load
Error: The module '<project_folder>/app/node_modules/electron-edge/build/Release/edge_nativeclr.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 51. This version of Node.js requires
NODE_MODULE_VERSION 53. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or`npm install`).

Using node 7.4.0, npm 4.0.5 as per electron's website:

Running npm install does indeed build electron-edge.

[pmoleri]

Hi, I guess this PR #21 is needed.

@SeanSnyders you probably can copy & paste the code in your tools/install.js

If that works, @kexplo should be able to cherry-pick that commit into the 1.6.4 branch.

[kexplo]

I forgot.
I just cherry-picked that commit.

And I mistakenly created a branch named electron_v1.6.4 with the wrong name, so I created a new branch named electron_v1.6.2.

Please make sure it works properly.
I can not use macOS now.

[me0262]

@SeanSnyders I'm getting this version conflict on Linux as well.
I've resolved by 'npm install electron-rebuild' and running 'node_modules/.bin/electron-rebuild'
This must be a problem on electron's side, because the latest Node is version 51 (unless they're supporting v8 LTS)

[Menendez-Oscar]

For those getting the mismatch error on Linux. You'll need to add a file .npmrc to the root directory of your project.

runtime = electron
target = 1.6.2
target_arch = armv7l
disturl = https://atom.io/download/atom-shell

This example works for raspberry pi running Ubuntu mate. Replace the target_arch with whatever your system's architecture is.