Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urls that are enclosed with ' instead of " are not matched correctly #54

Open
regevbr opened this issue Mar 26, 2018 · 2 comments · May be fixed by #55
Open

urls that are enclosed with ' instead of " are not matched correctly #54

regevbr opened this issue Mar 26, 2018 · 2 comments · May be fixed by #55

Comments

@regevbr
Copy link

regevbr commented Mar 26, 2018

This happens because of the path regex that should be changed to const path = '(?:[/?#][^\\s"\']*)?';
@alexpusch alexpusch linked a pull request Mar 29, 2018 that will close this issue
Open
@niftylettuce
Copy link
Collaborator

See my comment in #55 https://github.com/niftylettuce/url-regex-safe.

@niftylettuce
Copy link
Collaborator

This has been added in url-safe-regex v0.0.4+ at https://github.com/niftylettuce/url-safe-regex. See apostrophe option in README for more insight. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't allow ' in path
2 participants
@niftylettuce @regevbr