Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent usage of instanceof patterns #6064

Open
ori0o0p opened this issue Nov 24, 2024 · 1 comment
Open

Inconsistent usage of instanceof patterns #6064

ori0o0p opened this issue Nov 24, 2024 · 1 comment
Labels
area/backend Needs backend code changes bug Something isn't working

Comments

@ori0o0p
Copy link

ori0o0p commented Nov 24, 2024

Describe the issue

Description

The codebase currently has mixed usage of instanceof patterns:

  • The modern pattern matching style (s instanceof String str)
  • The traditional style (s instanceof String) which requires explicit casting.

This inconsistency can lead to reduced code readability and potential confusion among contributors.

Existing Code 1 image
Existing Code 2 image

Environment

  • Kestra Version: develop
@ori0o0p ori0o0p added area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working labels Nov 24, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 24, 2024
@MilosPaunovic
Copy link
Member

@ori0o0p PRs are always welcome 🙂

@MilosPaunovic MilosPaunovic removed the area/frontend Needs frontend code changes label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/backend Needs backend code changes bug Something isn't working
Projects
Issues
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MilosPaunovic @ori0o0p