Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the import functionality to accept zipped .yaml files (rather than only .yml) #6042

Closed
anna-geller opened this issue Nov 21, 2024 · 2 comments · Fixed by #6090
Closed

Adjust the import functionality to accept zipped .yaml files (rather than only .yml) #6042

anna-geller opened this issue Nov 21, 2024 · 2 comments · Fixed by #6090
Assignees
@Skraye
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working

Comments

@anna-geller
Copy link
Member

Describe the issue

It seems that current export/import functionality relies on files being .yml — trying to import a zip file of flows with .yaml extension gives error:

At yaml: special characters are not allowed at [Source: (StringReader); line: 1, column: 1] Caused by: special characters are not allowed

image

Environment

  • Kestra Version: develop
@anna-geller anna-geller added bug Something isn't working area/backend Needs backend code changes area/frontend Needs frontend code changes labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 21, 2024
@kratosmy
Copy link
Contributor

I tried with some .yaml files archived to a .zip but no error is found. Could you provide the test file?

@Skraye
Copy link
Member

Skraye commented Nov 25, 2024

The real issue is that Mac compression add some meta files that will be handled by Kestra and throw an error :
image

Skraye added a commit that referenced this issue Nov 25, 2024
@Skraye
fix(controller): Return failing file/flow when doing flow import
cdae2f1 
close #6042
@Skraye Skraye mentioned this issue Nov 25, 2024
Merged
Skraye added a commit that referenced this issue Nov 26, 2024
@Skraye
fix(controller): Return failing file/flow when doing flow import
6a9df53 
close #6042
@Skraye Skraye closed this as completed in 654d30e Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Issues Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skraye Skraye

Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working
Projects
Issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(controller): Return failing file/flow when doing flow import kestra-io/kestra
3 participants
@Skraye @kratosmy @anna-geller