Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug outputs, pebble expression issue #5991

Open
MilosPaunovic opened this issue Nov 19, 2024 · 6 comments · May be fixed by #6062
Open

Debug outputs, pebble expression issue #5991

MilosPaunovic opened this issue Nov 19, 2024 · 6 comments · May be fixed by #6062
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors kind/customer-request Requested by one or more customers

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Nov 19, 2024

If you have a task with an id that contains dashes, when moving to the Outputs tab, you get this incorrect example:
image

It should be {{ outputs['fetch-and-validate-ticket-data'] }}.

@MilosPaunovic MilosPaunovic added bug Something isn't working area/frontend Needs frontend code changes kind/customer-request Requested by one or more customers good first issue Great issue for new contributors labels Nov 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 19, 2024
@MilosPaunovic
Copy link
Member Author

MilosPaunovic commented Nov 19, 2024

Another one related to Outputs, are you willing to handle this one also @ManojTauro?

@Piyush-r-bhaskar
Copy link
Contributor

Hi @MilosPaunovic

Can it be assigned to me ?

@ManojTauro
Copy link
Contributor

Yes @MilosPaunovic. I can work on the issue this weekend. I hope that's okay.

Also, could you please share an example flow to reproduce this?

Thank you

@MilosPaunovic
Copy link
Member Author

@Ben8t Could you provide the example flow here?

@Piyush-r-bhaskar As @ManojTauro already close few issues closely related to this topic, it just makes more sense for him to tackle it. You can take your pick from the backlog if you're willing to help us! 🙂

@Ben8t
Copy link
Member

Ben8t commented Nov 20, 2024

@ManojTauro here is a sample flow

id: test-dash
namespace: kestra.test

tasks:
  - id: return-dash
    type: io.kestra.plugin.core.debug.Return
    format: "Hello"

The outputs format should be {{ outputs["return-dash"] }} in this case (and not {{ outputs.return-dash }})

@ManojTauro
Copy link
Contributor

Hi @MilosPaunovic I have created a PR for this issue. Please review.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors kind/customer-request Requested by one or more customers
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants