Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give commands puts items in disabled offhand #704

Open
GamefactsIG opened this issue Jan 14, 2024 · 2 comments
Open

Give commands puts items in disabled offhand #704

GamefactsIG opened this issue Jan 14, 2024 · 2 comments
Labels
investigate We have yet to investigate this issue non-template Please follow the issue template!

Comments

@GamefactsIG
Copy link

When a player obtains an item through i.e. /give , /i or a as a crate reward with a full inventory, item goes into offhand.

Information

  • Server Version:
  • 1.20.4
  • OldCombatMechanics version:
  • 2.0.1
  • Server Log File:
Server Log
  • OldCombatMechanics config file:
config.yml

Problem Description

To Reproduce

Steps to reproduce the behavior:

  1. Give yourself a full inventory
  2. Give yourself extra items
  3. Items will be in offhand

Expected Behaviour

Item should drop on floor due to being blocked

Actual Behaviour

Item goes in offhand

@GamefactsIG GamefactsIG added the investigate We have yet to investigate this issue label Jan 14, 2024
@GamefactsIG GamefactsIG changed the title Spam clicking Offhand being exploited Jan 14, 2024
@kernitus kernitus added the non-template Please follow the issue template! label Jan 14, 2024
@kernitus
Copy link
Owner

Please fill in the issue template properly and provide your config.yml

@kernitus kernitus changed the title Offhand being exploited Give commands puts items in disabled offhand Mar 16, 2024
@kernitus
Copy link
Owner

Not sure if much can be done about this. If a player has access to the /give and /item commands surely they can be expected to use the offhand? We can listen to the PlayerCommandPreprocessEvent and try to intercept these commands but that can be flaky and also would only work with the built-in Minecraft commands and not with any other plugins'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate We have yet to investigate this issue non-template Please follow the issue template!
Projects
None yet
Development

No branches or pull requests

2 participants