Skip to content

Commit

Permalink
config: rt-tests: fix MLOCKALL getting set to True
Browse files Browse the repository at this point in the history
When MLOCKALL is set to 'true', the lava job has MLOCKALL becomes true
[1] which in turn translates to "True" while job execution [2]. It
causes error as the test expects true instead of True.

  ./pi-stress.sh -D 60s -m True -r false -w hackbench
  ./pi-stress.sh: 37: True: not found

Fix it by using double quotes inside single quotes.
- First set of quotations allows Jinja template engine to treat it as a
  string
- Second set is for LAVA to also treat is as string and prevent YAML
  parser from making it a bool

[3] is successful job after this change.

[1] https://lava.collabora.dev/scheduler/job/15562666/definition#defline43
[2] https://lava.collabora.dev/scheduler/job/15562666#L220
[3] https://lava.collabora.dev/scheduler/job/15790058

Relates kernelci/kernelci-project#439
Co-authored-by: Paweł Wieczorek <[email protected]>
Signed-off-by: Muhammad Usama Anjum <[email protected]>
  • Loading branch information
musamaanjum authored and nuclearcat committed Sep 28, 2024
1 parent 4121401 commit 3b8eb56
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion config/runtime/tests/rt-tests.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
PRIORITY: {{ priority|default('98') }}
THREADS: {{ threads|default('2') }}
{% elif tst_cmd == 'pi-stress' %}
MLOCKALL: {{ mlockall|default('true') }}
MLOCKALL: {{ mlockall|default('"true"') }}
{% elif tst_cmd == 'rt-migrate-test' %}
PRIORITY: {{ priority|default('90') }}
{% elif tst_cmd == 'signaltest' %}
Expand Down

0 comments on commit 3b8eb56

Please sign in to comment.