Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotations containing non-word characters end up backwards at the start #52

Open
mastermaq opened this issue Jun 2, 2021 · 1 comment

Comments

@mastermaq
Copy link

Currently, a quotation such as:

"(They) are our trusted and respected neighbours, business partners, and friends," read a press release.

Gets converted into:

”(They) are our trusted and respected neighbours, business partners, and friends,” read a press release.

Note the backwards character at the start.

The issue is on Line 5 of replacements.js. Changing the regex to something like (\W|^)"(\w|\(|') would account for a parenthesis or single quote at the start of a quotation, which is not uncommon. Do you see any other problems with a change like this?

@mastermaq mastermaq changed the title Quotations containing non-word characters don't work Quotations containing non-word characters end up backwards at the start Jun 2, 2021
@bbernicker
Copy link

I just want to second this issue and add that it is fairly common to have the first character in a quote be [. This is because brackets are used to indicate that the quote, including the capitalization of the first letter, has been changed.
Consequently, "This is a quote" might be excerpted to "[A] quote." or used in a sentence like: I have already mentioned that "[t]his is a quote."). Indicating changes in this manner is required by MLA style (MLA Handbook 8th, 75) and Bluebook style (Rule 5.2(a)) and is permitted in Chicago Style (CMS 2003, 447).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants