Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinman Tiantang: Fix image blank #7067

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

pjy612
Copy link
Contributor

@pjy612 pjy612 commented Jan 8, 2025

Closes #7043

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@Smol-Ame

This comment was marked as resolved.

@pjy612
Copy link
Contributor Author

pjy612 commented Jan 8, 2025

I've reopened the previous issue request, put "Closes #7043" in your pull request description please

done.

@AwkwardPeak7 AwkwardPeak7 merged commit 766b984 into keiyoushi:main Jan 8, 2025
23 checks passed
@bigfuji
Copy link

bigfuji commented Jan 10, 2025

some comic like https://18comic-daima.org/photo/1053634 still blank

@pjy612
Copy link
Contributor Author

pjy612 commented Jan 10, 2025

some comic like https://18comic-daima.org/photo/1053634 still blank

18comic-daima.org I cannot access this node.
I tested 18comic-dwo.cc, it work.

If you are sure that there is still a problem, you can only raise the issue and let other experts to investigate

@pjy612 pjy612 deleted the jinmantiantang branch January 10, 2025 14:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinman Tiantang comic Display blank
4 participants