Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of run_tests #12

Closed
GoogleCodeExporter opened this issue Apr 29, 2015 · 1 comment
Closed

Fix return value of run_tests #12

GoogleCodeExporter opened this issue Apr 29, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

The way run_tests is currently implemented leads to problems with the exit 
status of the test run.

The line

return sea_tests_failed == 0;

returns 1 if the comparison succeeds. However, the exit status 1 stands for 
failure.

I would propose the following fix:

if (sea_tests_failed == 0) {
  return 0;
else {
  return -1;
}

Original issue reported on code.google.com by [email protected] on 17 Aug 2014 at 4:56

@keithn
Copy link
Owner

keithn commented Sep 30, 2016

see #13

@keithn keithn closed this as completed Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants