@josephsl

Hello @josephsl!
Could you review please?

Hi,

I see. This does help with resolving freezes when memory info is retrieved the first time. However, I have some concerns with this PR:

1. Is there reason for separating memory calculation into its own module? I think the contents of the memory module can be part of the main global plugin module or the function bodies be part of memory info script (I'm testing this approach at the moment).
2. If memory module is needed, I advise changing the indentation type from four spaces to tabs.
3. I assume the PR works with NVDA 2024.2. If not, please test that configuration as 2024.2 is the minimum NVDA version declared in the add-on manifest (this is because the proposed swap memory calculation involves using Widows internal modules inside psutil).

Thanks.

Is there reason for separating memory calculation into its own module? I think the contents of the memory module can be part of the main global plugin module or the function bodies be part of memory info script (I'm testing this approach at the moment).

I don’t see a big difference in where exactly the code is located; I believe that, if possible, the components should be separated into different modules.

If memory module is needed, I advise changing the indentation type from four spaces to tabs.

No problem, I'll commit it within an hour.

please test that configuration as 2024.2 is the minimum NVDA version declared in the add-on manifest

Tested it. Works correctly in 2024.2.

Hi,

Approved with follow-up change: memory functions are not separated into the memory module to align with other scripts. We can revisit this follow-up change if a PR to separate psutil calls into a separate module is warranted.

Thanks.