Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access keys not visible in the Light / Dark themes #7325

Open
ogmios-voice opened this issue Jan 23, 2022 · 0 comments · May be fixed by #11679
Open

Access keys not visible in the Light / Dark themes #7325

ogmios-voice opened this issue Jan 23, 2022 · 0 comments · May be fixed by #11679
Assignees
@phoerious
Labels
theme

Comments

@ogmios-voice
Copy link

Overview

Unlike in case of the Classic theme KeePassXC does not underline the access keys (in the menus, in dialog boxes, etc.) while using the Light / Dark themes.
(Note: in Windows turning on "Underline access keys when available" can help w/ the detection.)

Steps to Reproduce

  1. Start application w/ Light/Dark theme.
  2. if "Underline access keys when available" is not turned on, press and release Alt to activate the menubar.

Expected Behavior

Access keys are underlined just as in the case of the Classic theme.

Actual Behavior

Access keys are not underlined.

Context

KeePassXC - Version 2.6.6
Revision: 9c108b9
Qt 5.15.2
Operating system: Windows 10 Version 2009
CPU architecture: x86_64
Kernel: winnt 10.0.19043
@phoerious phoerious removed the bug label Nov 22, 2024
droidmonkey added a commit that referenced this issue Jan 19, 2025
@droidmonkey
Enable access key underline of menu bar items when focused
68002c5 
* Fixes #7325
droidmonkey added a commit that referenced this issue Jan 19, 2025
@droidmonkey
Enable access key underline of menu bar items when focused
4993d96 
* Fixes #7325
@droidmonkey droidmonkey linked a pull request Jan 20, 2025 that will close this issue
Draft
droidmonkey added a commit that referenced this issue Jan 20, 2025
@droidmonkey
Enable access key underline of menu bar items when focused
b12b67b 
* Fixes #7325

Qt 5.x defaults to always show mnemonic underlines in menus. Qt 6.x fixes this, but we can't port the fix since it relies on private theme namespaces. Anyway, to get around this, simply check if the widget is a menubar and focused. If so, we draw the underlines. Only applies when the user actually presses ALT so this is desired behavior.

NOTE: Underlines in menus will disappear once you focus on the menu, still working on this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phoerious phoerious

Labels
theme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show access key underline (mnemonics) of menu items on focus keepassxreboot/keepassxc
3 participants
@phoerious @droidmonkey @ogmios-voice